Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tail: Cargo.toml: Remove unneeded features of uucore and the nix dependency #4376

Merged
merged 1 commit into from
Feb 16, 2023

Conversation

Joining7943
Copy link
Contributor

@Joining7943 Joining7943 commented Feb 16, 2023

This pr removes the unused features ringbuffer and lines of the uucore dependency. The nix dependency wasn't in use either, so it's removed, too.

@Joining7943 Joining7943 changed the title tail: Cargo.toml: Remove unneeded features of uucore dependency tail: Cargo.toml: Remove unneeded features of uucore dependency Feb 16, 2023
@Joining7943 Joining7943 changed the title tail: Cargo.toml: Remove unneeded features of uucore dependency tail: Cargo.toml: Remove unneeded features of uucore and the nix dependency Feb 16, 2023
@sylvestre
Copy link
Sponsor Contributor

cool
how did you notice that?

@Joining7943
Copy link
Contributor Author

I had to adjust the Cargo.toml file in a pr because of the change to workspace.dependencies and then I noticed the unused dependencies. It's a little bit my fault too because I removed the need for these dependencies in some pr before, but didn't notice they're not in use elsewhere.

@tertsdiepraam
Copy link
Member

tertsdiepraam commented Feb 16, 2023

Hmm too bad cargo udeps doesn't flag this. I wonder if we can run it per util too and get a warning automatically.

Edit: udeps doesn't consider it "unused" because it's used via uucore. It does give this warning when I run it from the tail directory though:

unused dependencies:
`uucore v0.0.17 (/home/terts/Programming/uutils/coreutils/src/uucore)`
└─── dependencies
     └─── "dunce"

So running it per util could still be useful.

@sylvestre sylvestre merged commit 361690c into uutils:main Feb 16, 2023
@Joining7943 Joining7943 deleted the tail-remove-unused-features branch February 16, 2023 21:57
@Joining7943
Copy link
Contributor Author

So running it per util could still be useful.

yeah I think too this would be great. In another issue/pr?

@tertsdiepraam
Copy link
Member

Yes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants