Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rm: Remove remove_dir_all dependency #4340

Merged
merged 1 commit into from
Feb 11, 2023
Merged

rm: Remove remove_dir_all dependency #4340

merged 1 commit into from
Feb 11, 2023

Conversation

howjmay
Copy link
Contributor

@howjmay howjmay commented Feb 10, 2023

Closes #4335

@github-actions
Copy link

GNU testsuite comparison:

GNU test failed: tests/tail-2/inotify-dir-recreate. tests/tail-2/inotify-dir-recreate is passing on 'main'. Maybe you have to rebase?

@github-actions
Copy link

GNU testsuite comparison:

GNU test failed: tests/misc/tee. tests/misc/tee is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/misc/timeout. tests/misc/timeout is passing on 'main'. Maybe you have to rebase?

tertsdiepraam
tertsdiepraam reviewed Feb 10, 2023
View reviewed changes
Copy link
Member

@tertsdiepraam tertsdiepraam left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay so I may have jumped the gun by creating an issue for it. Looking into this some more, there's still this open issue: rust-lang/rust#29497. But I'm not really sure how big of an issue that is and there have also been a lot of improvements over the years. Ideally we'd have some test case for it.

@sylvestre do you think we should try this?

deny.toml Outdated
@@ -60,7 +60,6 @@ highlight = "all"
# spell-checker: disable
skip = [
# tempfile
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove this line as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@sylvestre
Copy link
Sponsor Contributor

At least, the CI is green here :)

@tertsdiepraam
Copy link
Member

Alright, we'll see how it goes, we can always revert :) Thanks @howjmay!

@tertsdiepraam tertsdiepraam merged commit d2c047c into uutils:main Feb 11, 2023
@howjmay
Copy link
Contributor Author

howjmay commented Feb 11, 2023

Thank you too!

@howjmay howjmay deleted the remove_dir_all branch February 11, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tertsdiepraam tertsdiepraam tertsdiepraam left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rm: remove remove_dir_all dependency
3 participants
@howjmay @sylvestre @tertsdiepraam