cut: refactor #4255
Merged
cut: refactor #4255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
sylvestre
force-pushed
the
cut_refactor
branch
from
f91dd60
to
c830b36
Compare
|
GNU testsuite comparison: |
|
looks good, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors
cut fieldlogic to reduce code duplication by factoring out the commonSearcer, which is templatized on a specificMatcher--ExactMatcherfor an explicit delimiter andWhitespaceMatcherfor white-space delimiter.before
SearcherandWhitespaceSearchercut_fieldsandcut_fields_whitespaceafter
MatchersSearchercut_fieldsby delegating actual work to specific functions