-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert #1571 “perf/factor ~ deduplicate divisors” #1842
Conversation
I ran the tests in a loop for 45 minutes, and confirmed there's no remaining bugs exposed by the tests (or at least, the ones left are highly unlikely to be hit) |
Performance wise, this seems to be a ~3% regression, so the complexity/speed trade-off seems to be definitely there. |
@sylvestre the CI failure seems unrelated to my changes, or |
are you sure?
|
Thanks! I'm not sure how I missed that |
@sylvestre It's also broken on
Generally, there seems to be a lot of failures in that testsuite, so something is really wrong. PS: I had a look, and the “Run GNU tests” task seems to just pull in whatever is in coreutils/coreutils, so pushes to the GNU repo can break it. Given that, and that it's broken on |
Force pushed to remove the empty commit I used to rerun CI |
It was a draft PR, not ready for merging, and its premature inclusion caused repeated issues, see 368f473 & friends.
This reverts commits 3743a3e, ce218e0, and b7b0c76.
Close #1841.