Skip to content

Commit

Permalink
Merge pull request #5030 from cakebaker/touch_use_parse_datetime
Browse files Browse the repository at this point in the history
touch: use parse_datetime instead of humantime_to_duration
  • Loading branch information
sylvestre committed Jul 3, 2023
2 parents 11b098f + e6ec149 commit 37cbfd1
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 24 deletions.
12 changes: 1 addition & 11 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# coreutils (uutils)
# * see the repository LICENSE, README, and CONTRIBUTING files for more information

# spell-checker:ignore (libs) libselinux gethostid procfs bigdecimal kqueue fundu mangen datetime uuhelp memmap
# spell-checker:ignore (libs) bigdecimal datetime fundu gethostid kqueue libselinux mangen memmap procfs uuhelp

[package]
name = "coreutils"
Expand Down
5 changes: 2 additions & 3 deletions src/uu/touch/Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# spell-checker:ignore humantime
# spell-checker:ignore datetime
[package]
name = "uu_touch"
version = "0.0.19"
Expand All @@ -18,8 +18,7 @@ path = "src/touch.rs"
[dependencies]
filetime = { workspace = true }
clap = { workspace = true }
# TODO: use workspace dependency (0.3) when switching from time to chrono
humantime_to_duration = "0.2.1"
parse_datetime = { workspace = true }
time = { workspace = true, features = [
"parsing",
"formatting",
Expand Down
18 changes: 9 additions & 9 deletions src/uu/touch/src/touch.rs
Original file line number Diff line number Diff line change
Expand Up @@ -84,13 +84,9 @@ pub fn uumain(args: impl uucore::Args) -> UResult<()> {
) {
(Some(reference), Some(date)) => {
let (atime, mtime) = stat(Path::new(reference), !matches.get_flag(options::NO_DEREF))?;
if let Ok(offset) = humantime_to_duration::from_str(date) {
let mut seconds = offset.whole_seconds();
let mut nanos = offset.subsec_nanoseconds();
if nanos < 0 {
nanos += 1_000_000_000;
seconds -= 1;
}
if let Ok(offset) = parse_datetime::from_str(date) {
let seconds = offset.num_seconds();
let nanos = offset.num_nanoseconds().unwrap_or(0) % 1_000_000_000;

let ref_atime_secs = atime.unix_seconds();
let ref_atime_nanos = atime.nanoseconds();
Expand Down Expand Up @@ -445,9 +441,13 @@ fn parse_date(s: &str) -> UResult<FileTime> {
}
}

if let Ok(duration) = humantime_to_duration::from_str(s) {
if let Ok(duration) = parse_datetime::from_str(s) {
let now_local = time::OffsetDateTime::now_local().unwrap();
let diff = now_local.checked_add(duration).unwrap();
let diff = now_local
.checked_add(time::Duration::nanoseconds(
duration.num_nanoseconds().unwrap(),
))
.unwrap();
return Ok(local_dt_to_filetime(diff));
}

Expand Down

0 comments on commit 37cbfd1

Please sign in to comment.