Skip to content

Commit

Permalink
Merge pull request #6020 from BenWiederhake/dev-cp-flaky-arg_interact…
Browse files Browse the repository at this point in the history
…ive_update

cp: fix flaky test test_cp_arg_interactive_update, document adjacent bug
  • Loading branch information
cakebaker committed Mar 1, 2024
2 parents 41f809d + ba1c6b0 commit 09048a3
Showing 1 changed file with 23 additions and 1 deletion.
24 changes: 23 additions & 1 deletion tests/by-util/test_cp.rs
Original file line number Diff line number Diff line change
Expand Up @@ -505,9 +505,31 @@ fn test_cp_arg_interactive_update() {
at.touch("a");
at.touch("b");
ucmd.args(&["-i", "-u", "a", "b"])
.pipe_in("N\n")
.pipe_in("")
.succeeds()
.no_stdout();
// Make extra sure that closing stdin behaves identically to piping-in nothing.
let (at, mut ucmd) = at_and_ucmd!();
at.touch("a");
at.touch("b");
ucmd.args(&["-i", "-u", "a", "b"]).succeeds().no_stdout();
}

#[test]
#[cfg(not(any(target_os = "android", target_os = "freebsd")))]
#[ignore = "known issue #6019"]
fn test_cp_arg_interactive_update_newer() {
// -u -i *WILL* show the prompt to validate the override.
// Therefore, the error code depends on the prompt response.
let (at, mut ucmd) = at_and_ucmd!();
at.touch("b");
at.touch("a");
ucmd.args(&["-i", "-u", "a", "b"])
.pipe_in("N\n")
.fails()
.code_is(1)
.no_stdout()
.stderr_is("cp: overwrite 'b'? ");
}

#[test]
Expand Down

0 comments on commit 09048a3

Please sign in to comment.