Add wasm32-wasi support for V3, V4, and V5 #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the wasm32 architecture is used with WASI, md5, getrandom, and sha1 are all available, so V3, V4, and V5 can be enabled.
sunfishcode
requested review from
Dylan-DPC-zz,
kinggoesgaming and
KodrAus
as code owners
|
An update: I have been trying to get the one heck of a mess that is our build system fixed. This might take sometime to get fixed. I want a good fix not just a system held together with duct tape. I am not sure how we handle post the shift to Github Actions complete. (Travis is completely broken for us now so...) |
|
bors r+ |
|
Build succeeded: |
bors-servo
added a commit
to servo/ipc-channel
that referenced
this pull request
Dec 26, 2020
Make it compile for wasm32-unknown-unknown and wasm32-wasi This uses the "inprocess" implementation for the WebAssembly targets, like Windows, Android and iOS already do. Note that this only compile with the master branch of the `uuid` crate, as uuid-rs/uuid#477 hasn't been published yet.
acfoltzer
added a commit
to acfoltzer/uuid
that referenced
this pull request
May 27, 2023
@sunfishcode added `wasm32-wasi` support in uuid-rs#477, but somewhere along the way it appears to have been broken or dropped. Thankfully, the reason for the breakage doesn't appear too deep: the `wasm-bindgen` support was enabled for all `wasm32` architectures, rather than just the `wasm32-unknown-unknown` target triple that [`wasm-bindgen` supports](https://rustwasm.github.io/wasm-bindgen/reference/rust-targets.html). This PR fixes the `cfg` expressions for `wasm-bindgen`-specific code so that they no longer catch `wasm32-wasi`, and now `wasm32-wasi` just works 🎉 To guard against future breakage, I added some `wasm32-wasi` testing infrastructure. A new CI target modeled on the `wasm-bindgen` target tests the `wasm32-wasi` implementation against `wasmtime`. Since test runners can't be specified at the command line, this requires a `.cargo/config` addition as well. I also noticed and fixed a typo in the existing `wasm-bindgen` CI target that I believe has been causing the tests to not run with any of the version features enabled.
This was referenced May 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm submitting a(n) feature
Description
When the wasm32 architecture is used with WASI, md5, getrandom, and sha1
are all available, so V3, V4, and V5 can be enabled.
Motivation
I'm porting an application that uses
uuidto WASI and would like to add support.Tests
cargo test --target=wasm32-wasi --all-featurespasses.