Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few fixes #49

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

A few fixes #49

wants to merge 3 commits into from

Conversation

chscorpio
Copy link

I found a bug in the RelativeTimeFormatter. Basically, Calendar defaults to using my local TimeZone which breaks when setting the time using the calculated relativeTime from a Calendar in a possibly different TimeZone. Along the same lines, the format date unit tests were failing because the offset was still relative to my time zone. Instead, explicitly constructing the Calendar with the German time zone. Also, setting Calendar HOUR to 1 without AM_PM is left to interpretation and wasn't working for me. Instead, explicitly setting HOUR_OF_DAY to 13 is consistently working.

Finally, while integrating with an SMPP service, the OptionalParameters for-each loop was throwing a NullPointerException likely because they didn't send any OptionalParameters. Instead, I just check for null before executing the for-each loop.

@TomasMorecom
Copy link

Hi. This project has been moved to https://github.com/opentelecoms-org/jsmpp
Please check if your problem has been corrected here, if not please add a pull request to that project instead.

Best Regards,
Tomas

@chscorpio
Copy link
Author

Thanks for the link. My problems were corrected in master but not yet released to the maven repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants