Add some new metrics for pod ephemeral storage #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ribbybibby Could you review this PR? |
ribbybibby
suggested changes
Sep 20, 2021
There was a problem hiding this comment.
Hi @superbrothers. Thanks for the contribution! It looks good.
A few things:
- Can you move the manifests to a separate PR? I'd like to review those separately.
- Could you implement the
inodesmetrics, like we do for the other fsstats?
superbrothers
force-pushed
the
ephemeral-storage
branch
from
a37ca88
to
2e24b9e
Compare
Closed
|
I've moved sample manifest files to #6. |
Yes, but I'm going to do it in a different PR. |
How come? Seems like it would fit into this one. |
superbrothers
force-pushed
the
ephemeral-storage
branch
2 times, most recently
from
231fd47
to
cfc51a6
Compare
|
I misread your comment:bow: I have added the following metrics:
|
superbrothers
force-pushed
the
ephemeral-storage
branch
from
cfc51a6
to
7e91d78
Compare
- `kube_summary_pod_ephemeral_storage_available_bytes`: Number of bytes of Ephemeral storage that aren't consumed by the pod - `kube_summary_pod_ephemeral_storage_capacity_bytes`: Number of bytes of Ephemeral storage that can be consumed by the pod - `kube_summary_pod_ephemeral_storage_used_bytes`: Number of bytes of Ephemeral storage that are consumed by the pod - `kube_summary_pod_ephemeral_storage_inodes_free`: Number of available Inodes for pod Ephemeral storage - `kube_summary_pod_ephemeral_storage_inodes`: Number of Inodes for pod Ephemeral storage - `kube_summary_pod_ephemeral_storage_inodes_used`: Number of used Inodes for pod Ephemeral storage
superbrothers
force-pushed
the
ephemeral-storage
branch
from
7e91d78
to
c8e6155
Compare
ribbybibby
approved these changes
Sep 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some new metrics for pod ephemeral storage.