Fix confusing creation/update names

[matiit]

No description provided.

[uw-infra]

Terraform plan output for

Cluster: dev-aws
Module: pubsub/kafka-shared-msk-account-identity
Path: dev-aws/kafka-shared-msk/account-identity
Commit ID: fe4a2d0e0d749ae8088a4bfd0fb1b17594e9e233

✅ Run Status: Ok, Run Summary: Plan: 1 to add, 0 to change, 1 to destroy.

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create
  - destroy

Terraform will perform the following actions:

  # module.account_identity_supply_address_relay.kafka_acl.group_acl["account-identity.legacy-account-supply-address-creation-events-relay"] will be destroyed
  # (because key ["account-identity.legacy-account-supply-address-creation-events-relay"] is not in for_each map)
  - resource "kafka_acl" "group_acl" {
      - acl_host                     = "*" -> null
      - acl_operation                = "Read" -> null
      - acl_permission_type          = "Allow" -> null
      - acl_principal                = "User:CN=account-platform/supply_address_relay" -> null
      - id                           = "User:CN=account-platform/supply_address_relay|*|Read|Allow|Group|account-identity.legacy-account-supply-address-creation-events-relay|Literal" -> null
      - resource_name                = "account-identity.legacy-account-supply-address-creation-events-relay" -> null
      - resource_pattern_type_filter = "Literal" -> null
      - resource_type                = "Group" -> null
    }

  # module.account_identity_supply_address_relay.kafka_acl.group_acl["account-identity.legacy-account-supply-address-update-events-relay"] will be created
  + resource "kafka_acl" "group_acl" {
      + acl_host                     = "*"
      + acl_operation                = "Read"
      + acl_permission_type          = "Allow"
      + acl_principal                = "User:CN=account-platform/supply_address_relay"
      + id                           = (known after apply)
      + resource_name                = "account-identity.legacy-account-supply-address-update-events-relay"
      + resource_pattern_type_filter = "Literal"
      + resource_type                = "Group"
    }

Plan: 1 to add, 0 to change, 1 to destroy.

To manually trigger plan again please post @terraform-applier plan dev-aws/kafka-shared-msk/account-identity as comment.