Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data infra exporter and data infra events topic #405

Merged
merged 2 commits into from
Jul 5, 2024

Conversation

martskins
Copy link
Contributor

No description provided.

@martskins martskins requested a review from a team as a code owner July 4, 2024 15:23
@martskins martskins force-pushed the add-data-infra-exporter branch 2 times, most recently from b599627 to 22db3fe Compare July 4, 2024 15:46

config = {
"remote.storage.enable" = "true"
"retention.bytes" = "-1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to confirm this config... you'll need infinite retention on it, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to be honest, this one is a new topic and it's for the data infra integration. Maybe it could do with less than infinite. I default to infinite because I'm concerned we'll later find out that actually we need to reconsume everything for whatever reason, but maybe there's a saner default for this topic specifically, considering it's specifically for this data infra use-case.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to find out for how long is UW required to keep this data?
We could also go with infinite and revisit later, but it would be good to settle this from the get go.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the data will be kept in braze anyways, so how long it lives in the topic will not necessarily match that I suppose. I've changed it to a month so that if something breaks we have plenty of time to fix it without risk of losing messages. I've asked data infra whether they have any recommendations for this value though, so won't merge just yet, but I guess a month is a saner value than forever for this topic.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't received an answer from data-infra yet, but given this is dev I'm happy to just stick with 1 month for it. We won't even have much data going through this one in dev anyways.

@martskins martskins merged commit d46f0f2 into main Jul 5, 2024
1 check passed
@martskins martskins deleted the add-data-infra-exporter branch July 5, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants