This repository has been archived by the owner on Sep 19, 2018. It is now read-only.
Introduce metric on errors from kube api calls #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ffilippopoulos
commented
Mar 27, 2018
ffilippopoulos
commented
- Add error handler to keep count of kube api errors
- Pin older go version to avoid certificates issue
1. Add error handler to keep count of kube api errors 2. Pin older go version to avoid certificates issue
george-angel
approved these changes
Mar 27, 2018
| @@ -9,7 +9,7 @@ RUN apk add --no-cache \ | |||
| && apk add --no-cache --virtual=.builddeps \ | |||
| -X http://dl-cdn.alpinelinux.org/alpine/edge/community \ | |||
| git \ | |||
| go \ | |||
| go=1.8.4-r0 \ | |||
There was a problem hiding this comment.
Could you also make a card to remove this, that is blocked with the link to the go issue?
|
Out of curiosity, why does the name contains "IO", is that also used for interacting with APIs as well as storage? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.