-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Statuser implementation #88
base: master
Are you sure you want to change the base?
Conversation
proximo/internal/proximoc/client.go
Outdated
@@ -284,3 +284,7 @@ func makeId() string { | |||
} | |||
return base64.URLEncoding.EncodeToString(random) | |||
} | |||
|
|||
func (p *ProducerConn) GrpcClient () *grpc.ClientConn { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
exported method ProducerConn.GrpcClient should have comment or be unexported
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comment added
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also it should be GRPCClient
although it looks a bit worse
https://stackoverflow.com/questions/39830166/glued-acronyms-and-golang-naming-convention
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed to GRPCClient
proximo/status.go
Outdated
return nil, ErrNotConnected | ||
} | ||
|
||
var working bool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
var (
working bool
problems []string
)
switch cc.GetState() {
looks better imho
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch
Looks good, but do you maybe want to try using substrate instead? https://github.com/uw-labs/substrate It gives you basically the same api with synchronous adapters, but you can also use the async version if you need better throughput. We did a bit of work there recently, so it might be hopefully better behaved than this old client... |
The same was suggested by @thinktainer and implementation is on the way. Question then is do we still want this added here for possible future use? |
I think, it's fine to merge, we just want to encourage people to use substrate more |
No description provided.