-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
USWDS-Site - POAM: September '24 #2815
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mahoneycm! Tests pass and no issues found in preview after testing several pages (Components, Docs, Utils, and Security).
Minor note, there's still a reference to Ruby 3.3.4 in README.md. Updated in be54418.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks as always for the helpful PR description, @mahoneycm
- Confirm that the link update is appropriate
- Confirm all references to ruby 3.3.4 have been updated
- Confirm I can run
npm install
,npm start
,npm run build
,npm run crawl
,npm test
without error
Summary
Installed available minor and patch updates for direct dependencies.
Important
This PR caught a Federalist build issue related to Ruby
3.3.4
. The issue appears unrelated to these changes but was caught due to generating a newgemfile.lock
. This PR downgrades Ruby to3.2.5
to avoid build errors.The federalist pages team is investigating and created this issue to track. Additional details in this slack thread (🔒)
Related issue
USWDS-Team - POAM: August 2024
Preview link
Preview link →
Major changes
3.2.5
to resolve Cloud Pages build error.glob-parent
postcss
https://design.va.gov/patterns/help-users-to/recover-from-errors#style-and-tone
Testing and review
npm install.
npm run build
and confirm there are no build errors.npm start
and confirm there are no build errors.npm test
and confirm there are no errors.npm run crawl
to test crawler script that usescheerio
package.Dependency updates
Before:
After:
Package updates
Gem updates