Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix prop syntax in validation component tutorial. #999

Merged
merged 1 commit into from
Aug 20, 2021

Conversation

ohsh6o
Copy link
Contributor

@ohsh6o ohsh6o commented Jul 22, 2021

Committer Notes

Closes #998.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you squashed any non-relevant commits and commit messages? [instructions]
  • Do all automated CI/CD checks pass?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them? N/A
  • Have you written new tests for your core changes, as applicable? N/A
  • Have you included examples of how to use your new feature(s)? N/A
  • Have you updated all OSCAL website and readme documentation affected by the changes you made? Changes to the OSCAL website can be made in the docs/content directory of your branch.

Copy link
Contributor

@iMichaela iMichaela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The proposed changes are fixing the bug by updating the example to OSCAL 1.0.0.

Copy link
Contributor

@david-waltermire david-waltermire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@david-waltermire david-waltermire merged commit 086b30b into usnistgov:main Aug 20, 2021
@david-waltermire david-waltermire modified the milestone: OSCAL 1.0.1 Jan 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Errors in Props in Validation Testing Tutorial
3 participants