Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation contribution link #995

Closed

Conversation

laurelmay
Copy link
Contributor

Committer Notes

The current "Improve this Page" link at the bottom of each page results in a GitHub 404 error.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you squashed any non-relevant commits and commit messages? [instructions]
  • Do all automated CI/CD checks pass?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?
  • Have you updated all OSCAL website and readme documentation affected by the changes you made? Changes to the OSCAL website can be made in the docs/content directory of your branch.

The current "Improve this Page" link at the bottom of each page results
in a GitHub 404 error.
Copy link
Contributor

@iMichaela iMichaela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The submitted change was reviewed and is correct. I am not approving the PR because we need to make sure the error does not have a deeper root - need to talk to @david-waltermire-nist. The link worked in the past and most likely was changed pointing incorrectly to oscal-content repo instead of OSCAL (docs/content) when the OSCAL content was moved to its own repo ( oscal-content repo).

@david-waltermire
Copy link
Contributor

@kylelaker I believe this is used in some pages to point to OSCAL content repository. I need to check if this change has other side effects as a result.

david-waltermire added a commit that referenced this pull request Aug 12, 2021
…rs: one for content pages, and the other for website pages
@david-waltermire
Copy link
Contributor

This was merged with some modifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken "Improve this page" link and timestamp at bottom of Profile Resolution documentation page
3 participants