Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Typos in Metaschema Model for OSCAL SSP #800

Closed
wants to merge 1 commit into from
Closed

Fix Typos in Metaschema Model for OSCAL SSP #800

wants to merge 1 commit into from

Conversation

ohsh6o
Copy link
Contributor

@ohsh6o ohsh6o commented Dec 9, 2020

Committer Notes

Fixes #799.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you squashed any non-relevant commits and commit messages? [instructions]
  • Do all automated CI/CD checks pass?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?
  • Have you updated all OSCAL website and readme documentation affected by the changes you made? Changes to the OSCAL website can be made in the docs/content directory of your branch.

@ohsh6o
Copy link
Contributor Author

ohsh6o commented Dec 9, 2020

I read the CONTRIBUTING.md document and thought I was mistaken about the ./src directory, let me know and I can close/relocate accordingly. Obviously, this is a minor fix in terms of priority anyway.

@ohsh6o ohsh6o changed the base branch from master to metaschema-m4-integration December 9, 2020 20:52
@ohsh6o
Copy link
Contributor Author

ohsh6o commented Dec 9, 2020

Per conversation with @brianrufgsa, he is working on the M4 branch and will fix this there, instead of me needing to rebase from that branch instead of master. Will close later today.

@ohsh6o ohsh6o changed the base branch from metaschema-m4-integration to master December 9, 2020 20:55
@brian-ruf
Copy link
Contributor

This will be addressed as part of PR #758.
Change has been made, but not yet merged with the metaschema-m4-integration branch associated with that PR.

@brian-ruf brian-ruf closed this Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minor Typos in Metaschema Model for OSCAL SSP
3 participants