Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue468 metaschema enhancements #484

Conversation

wendellpiez
Copy link
Contributor

@wendellpiez wendellpiez commented Sep 3, 2019

Committer Notes

Implementing field/@in-xml on "markup-multiline" fields. The permitted values are with-wrapper (assumed by default) and unwrapped.

Changes:

  • Metaschema XSD permits this attribute
  • Metaschema Schematron validates its use (only on fields with as-type='markup-multiline
  • Generated XSD now requires (or doesn't) the wrapper element
  • Generated JSON Schema is unchanged
  • Both conversion pathways support the feature

Still to do (at time of first draft PR):

  • Documentation
  • Stress testing including in combination with group-as features

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you squashed any non-relevant commits and commit messages? [instructions]
  • Do all automated CI/CD checks pass?

@wendellpiez wendellpiez force-pushed the issue468-metaschema-enhancements branch from 96328ab to 8401f5b Compare September 4, 2019 18:02
@david-waltermire
Copy link
Contributor

This has been integrated into PR #492.

@wendellpiez wendellpiez deleted the issue468-metaschema-enhancements branch October 2, 2019 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants