Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add assessment-assets assembly to POAM model. #1291 #1417

Merged
merged 1 commit into from
Aug 21, 2022
Merged

Add assessment-assets assembly to POAM model. #1291 #1417

merged 1 commit into from
Aug 21, 2022

Conversation

Compton-US
Copy link
Contributor

Added assembly to support assessment assets.
(Model already imports from oscal_assessment-common_metaschema.xml)

Expected model change:

plan-of-action-and-milestones:
  local-definitions [0 or 1]: {
    components [0 or 1]: [ … ],
    inventory-items [0 or 1]: [ … ],
+   assessment-assets [0 or 1]: [ … ],
    remarks [0 or 1]: markup-multiline,
  },

@Compton-US Compton-US changed the base branch from main to develop August 17, 2022 17:57
@david-waltermire david-waltermire force-pushed the feature-add-poam-assessment-assets-assembly-issue-1291 branch from bce0b25 to 9e6197c Compare August 21, 2022 02:37
david-waltermire
david-waltermire approved these changes Aug 21, 2022
View reviewed changes
Copy link
Contributor

@david-waltermire david-waltermire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@david-waltermire david-waltermire linked an issue Aug 21, 2022 that may be closed by this pull request
assessment-assets missing in POAM's local-definitions #1291
Closed
@david-waltermire david-waltermire merged commit 05c96dc into usnistgov:develop Aug 21, 2022
david-waltermire pushed a commit that referenced this pull request Aug 23, 2022
@Compton-US @david-waltermire
Add assessment-assets assembly to local-definitions assembly in POAM …
9aeea54 
…model. #1291 (#1417)
aj-stein-nist pushed a commit to aj-stein-nist/OSCAL-forked that referenced this pull request Oct 6, 2022
@Compton-US @aj-stein-nist
Add assessment-assets assembly to local-definitions assembly in POAM …
cbe8bbc 
…model. usnistgov#1291 (usnistgov#1417)
aj-stein-nist pushed a commit that referenced this pull request Oct 18, 2022
@Compton-US @aj-stein-nist
Add assessment-assets assembly to local-definitions assembly in POAM …
2ee7bde 
…model. #1291 (#1417)
david-waltermire pushed a commit that referenced this pull request Oct 31, 2022
@Compton-US @david-waltermire
Add assessment-assets assembly to local-definitions assembly in POAM …
2c41f0f 
…model. #1291 (#1417)
aj-stein-nist pushed a commit to aj-stein-nist/OSCAL-forked that referenced this pull request Jan 10, 2023
@Compton-US @aj-stein-nist
Add assessment-assets assembly to local-definitions assembly in POAM …
32fbf44 
…model. usnistgov#1291 (usnistgov#1417)
aj-stein-nist pushed a commit to aj-stein-nist/OSCAL-forked that referenced this pull request Feb 6, 2023
@Compton-US @aj-stein-nist
Add assessment-assets assembly to local-definitions assembly in POAM …
50915cf 
…model. usnistgov#1291 (usnistgov#1417)
aj-stein-nist pushed a commit to aj-stein-nist/OSCAL-forked that referenced this pull request Jun 29, 2023
@Compton-US @aj-stein-nist
Add assessment-assets assembly to local-definitions assembly in POAM …
18e6ce5 
…model. usnistgov#1291 (usnistgov#1417)
aj-stein-nist pushed a commit to aj-stein-nist/OSCAL-forked that referenced this pull request Jul 10, 2023
@Compton-US @aj-stein-nist
Add assessment-assets assembly to local-definitions assembly in POAM …
b4f0485 
…model. usnistgov#1291 (usnistgov#1417)
aj-stein-nist pushed a commit to galtm/OSCAL that referenced this pull request Sep 28, 2023
@Compton-US @aj-stein-nist
Add assessment-assets assembly to local-definitions assembly in POAM …
a80dc53 
…model. usnistgov#1291 (usnistgov#1417)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-waltermire david-waltermire david-waltermire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

assessment-assets missing in POAM's local-definitions
2 participants
@Compton-US @david-waltermire