Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated data type documentation and schema constraints to address regex issues #1265

Conversation

david-waltermire
Copy link
Contributor

@david-waltermire david-waltermire commented May 13, 2022

Committer Notes

  • Updated Metaschema toolchain to correct schema regex bugs. Resolves Error in datetime-regex #1260.
  • Updated data type documentation to be consistent with schemas.

All Submissions:

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?
  • Have you updated all OSCAL website and readme documentation affected by the changes you made? Changes to the OSCAL website can be made in the docs/content directory of your branch.

Copy link
Contributor

@aj-stein-nist aj-stein-nist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to read a few times, test the regexes, and got distracted by xs:restriction and xs:pattern annotations but this looks good. I have a follow-on question I will ask in the discussion board, but it is outside the scope of the PR.

@aj-stein-nist
Copy link
Contributor

The implied question that could or couldn't be a later enhancement I added in #1266.

@david-waltermire david-waltermire merged commit b38b86e into usnistgov:main May 13, 2022
@david-waltermire david-waltermire deleted the issue1260-update-metaschema-plus-docs branch May 13, 2022 13:54
aj-stein-nist pushed a commit to aj-stein-nist/OSCAL-forked that referenced this pull request May 16, 2022
…ex issues (usnistgov#1265)

* Updated data type documentation to be consistent with schemas
* Updated Metaschema toolchain to correct schema regex bugs. Resolves usnistgov#1260.
Rene2mt pushed a commit to Rene2mt/OSCAL that referenced this pull request May 17, 2022
…ex issues (usnistgov#1265)

* Updated data type documentation to be consistent with schemas
* Updated Metaschema toolchain to correct schema regex bugs. Resolves usnistgov#1260.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in datetime-regex
2 participants