Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Profile Resolution handling groups #1141

Closed
stephenbanghart opened this issue Feb 17, 2022 · 1 comment · Fixed by #1172
Closed

Profile Resolution handling groups #1141

stephenbanghart opened this issue Feb 17, 2022 · 1 comment · Fixed by #1172
Assignees
@stephenbanghart
Labels
Discussion Needed This issues needs to be reviewed by the OSCAL development team. enhancement User Story
Milestone
OSCAL 1.0.2

Comments

@stephenbanghart
Copy link
Contributor

stephenbanghart commented Feb 17, 2022 •
edited
Loading

<p>Some source catalogs use <src>group</src> objects to place controls into arbitrary groupings. Tools will need to be aware of these groups when executing the "merge" phase below, as they will duplicated into the output under the "as-is" mode and can be referenced in "custom" mode. The naïve intermediate approach would keep all groups until all other phases are complete, but implementations may find it more performant to look ahead and prune unused groups early.</p>

This section in the Import phase of Profile Resolution is potentially under specified. Further requirements clarifying the fate of non-control, non-group elements under a group are probably needed to ensure deterministic output. This is particularly notable for the "custom" merge mode with ID matched group importing.

Ongoing work on requirement driven testing should provide further insight. #1087
@david-waltermire david-waltermire added the Discussion Needed This issues needs to be reviewed by the OSCAL development team. label Feb 24, 2022
@david-waltermire
Copy link
Contributor

@stephenbanghart is scheduling a meeting with the NIST design team for the week of 3/7/2022.

@david-waltermire david-waltermire added this to the OSCAL 1.0.2 milestone Feb 25, 2022
stephenbanghart pushed a commit to stephenbanghart/OSCAL that referenced this issue Mar 14, 2022
@canb227
Specification changes, usnistgov#1141 usnistgov#1142 usnistgov#1155
8508bda
@stephenbanghart stephenbanghart mentioned this issue Mar 14, 2022
Merged
stephenbanghart pushed a commit to stephenbanghart/OSCAL that referenced this issue Mar 14, 2022
@canb227
Specification changes, usnistgov#1141 usnistgov#1142 usnistgov#1155
43f8634
stephenbanghart pushed a commit to stephenbanghart/OSCAL that referenced this issue Mar 15, 2022
@canb227
Specification changes, usnistgov#1141 usnistgov#1142 usnistgov#1155
1b45491
@david-waltermire david-waltermire linked a pull request Mar 17, 2022 that will close this issue
Profile Resolution 1.0.2 Updates #1172
Merged
david-waltermire pushed a commit that referenced this issue Mar 17, 2022
@stephenbanghart @canb227 @aj-stein-nist
Profile Resolution 1.0.2 Updates (#1172)
4720c14 
* Specification changes, #1141 #1142 #1155
* Mapping documentation, UUID RFC reference
* Apply suggestions from AJ's review

Co-authored-by: Stephen Banghart <stephen.banghart@outlook.com>
Co-authored-by: Alexander Stein <alexander.stein@nist.gov>
david-waltermire pushed a commit that referenced this issue Mar 18, 2022
@stephenbanghart @canb227
@aj-stein-nist @david-waltermire
Profile Resolution 1.0.2 Updates (#1172)
ddc97a2 
* Specification changes, #1141 #1142 #1155
* Mapping documentation, UUID RFC reference
* Apply suggestions from AJ's review

Co-authored-by: Stephen Banghart <stephen.banghart@outlook.com>
Co-authored-by: Alexander Stein <alexander.stein@nist.gov>
iMichaela pushed a commit to iMichaela/OSCAL that referenced this issue Apr 7, 2022
@stephenbanghart @canb227
@aj-stein-nist @iMichaela
Profile Resolution 1.0.2 Updates (usnistgov#1172)
4754e85 
* Specification changes, usnistgov#1141 usnistgov#1142 usnistgov#1155
* Mapping documentation, UUID RFC reference
* Apply suggestions from AJ's review

Co-authored-by: Stephen Banghart <stephen.banghart@outlook.com>
Co-authored-by: Alexander Stein <alexander.stein@nist.gov>
Rene2mt pushed a commit to Rene2mt/OSCAL that referenced this issue May 17, 2022
@stephenbanghart @canb227
@aj-stein-nist @Rene2mt
Profile Resolution 1.0.2 Updates (usnistgov#1172)
0a126e2 
* Specification changes, usnistgov#1141 usnistgov#1142 usnistgov#1155
* Mapping documentation, UUID RFC reference
* Apply suggestions from AJ's review

Co-authored-by: Stephen Banghart <stephen.banghart@outlook.com>
Co-authored-by: Alexander Stein <alexander.stein@nist.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stephenbanghart stephenbanghart

Labels
Discussion Needed This issues needs to be reviewed by the OSCAL development team. enhancement User Story
Projects
None yet
Milestone
OSCAL 1.0.2
Development

Successfully merging a pull request may close this issue.

Profile Resolution 1.0.2 Updates stephenbanghart/OSCAL
2 participants
@david-waltermire @stephenbanghart