'Authentication failed' message converted in plain text #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A failed authentication on /token no more returns an HTML message. Before this commit, the /token endopoint was returning thw Wordpress default error for a failed login. This was an HTML string with a link to recover the password. Dealing with REST API it's better to always have plain text as a message
sun
reviewed
Apr 5, 2024
| @@ -183,7 +183,7 @@ public function get_token( WP_REST_Request $request ) { | |||
| 'success' => false, | |||
| 'statusCode' => 401, | |||
| 'code' => $error_code, | |||
| 'message' => strip_tags( $user->get_error_message( $error_code ) ), | |||
| 'message' => strip_tags('Authentication failed: '.$error_code), | |||
There was a problem hiding this comment.
The existing code removes HTML tags already, so I'm not sure what this PR actually changes (other than removing a potentially more helpful error message for the end-user)…?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A failed authentication on /token no more returns an HTML message.
Before this commit, the /token endopoint was returning thw Wordpress default error for a failed login. This was an HTML string with a link to recover the password.
Dealing with REST API it's better to always have plain text as a message