Bugfix/tab focus #448
Closed
Bugfix/tab focus #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@helloanoop Can you review this and let me know if something needs to be added? |
|
This is a QOL improvement. Will review and merge this post our 1.0.0 launch on Oct 28th. |
| @@ -78,10 +79,30 @@ const Modal = ({ | |||
| }; | |||
|
|
|||
| useEffect(() => { | |||
| document.addEventListener('keydown', escFunction, false); | |||
There was a problem hiding this comment.
I'd recommend abstracting this to a custom hook that handles focus trap
|
|
||
| console.log(focusableElements); |
|
Hey @srikary12 ! Thanks for working on this. We made some updates on top of your PR and the changes have been merged in #3075 Closing this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to implement Tab Order as discussed in #129
The Tab order stays inside Modal.
This is my first issue, please let me know if I miss something. 😄