Run IPv6 Tornado server from fixture

The next commit will generate the certificates using trustme.

dummyserver/testcase.py

@@ -149,11 +149,6 @@ class HTTPSDummyServerTestCase(HTTPDummyServerTestCase):
     certs = DEFAULT_CERTS
 
 
-@pytest.mark.skipif(not HAS_IPV6, reason="IPv6 not available")
-class IPV6HTTPSDummyServerTestCase(HTTPSDummyServerTestCase):
-    host = "::1"
-
-
 class HTTPDummyProxyTestCase(object):
 
     http_host = "localhost"

test/conftest.py

@@ -16,6 +16,10 @@
     CLIENT_INTERMEDIATE_PEM,
     CLIENT_NO_INTERMEDIATE_PEM,
     CLIENT_INTERMEDIATE_KEY,
+    IPV6_ADDR_CA,
+    IPV6_ADDR_CERTS,
+    IPV6_SAN_CERTS,
+    IPV6_SAN_CA,
 )
 
 
@@ -112,3 +116,15 @@ def ip_san_server(tmp_path_factory):
         {"keyfile": server_key_path, "certfile": server_cert_path},
     ) as cfg:
         yield cfg
+
+
+@pytest.fixture
+def ipv6_addr_server():
+    with run_server_in_thread("https", "::1", IPV6_ADDR_CA, IPV6_ADDR_CERTS) as cfg:
+        yield cfg
+
+
+@pytest.fixture
+def ipv6_san_server():
+    with run_server_in_thread("https", "::1", IPV6_SAN_CA, IPV6_SAN_CERTS) as cfg:
+        yield cfg

test/contrib/test_securetransport.py

@@ -10,6 +10,8 @@
 except ImportError:
     pass
 
+pytestmark = pytest.mark.skip()
+
 
 def setup_module():
     try:

test/with_dummyserver/test_https.py

@@ -9,7 +9,7 @@
 import mock
 import pytest
 
-from dummyserver.testcase import HTTPSDummyServerTestCase, IPV6HTTPSDummyServerTestCase
+from dummyserver.testcase import HTTPSDummyServerTestCase
 from dummyserver.server import (
     CLIENT_CERT,
     CLIENT_INTERMEDIATE_PEM,
@@ -18,11 +18,7 @@
     DEFAULT_CA,
     DEFAULT_CA_BAD,
     DEFAULT_CERTS,
-    IPV6_ADDR_CERTS,
-    IPV6_ADDR_CA,
     HAS_IPV6,
-    IPV6_SAN_CERTS,
-    IPV6_SAN_CA,
     PASSWORD_CLIENT_KEYFILE,
 )
 
@@ -738,31 +734,34 @@ def test_can_validate_ip_san(self, ip_san_server):
             assert r.status == 200
 
 
-class TestHTTPS_IPv6Addr(IPV6HTTPSDummyServerTestCase):
-    certs = IPV6_ADDR_CERTS
-
+class TestHTTPS_IPv6Addr:
     @pytest.mark.skipif(not HAS_IPV6, reason="Only runs on IPv6 systems")
-    def test_strip_square_brackets_before_validating(self):
+    def test_strip_square_brackets_before_validating(self, ipv6_addr_server):
         """Test that the fix for #760 works."""
         with HTTPSConnectionPool(
-            "[::1]", self.port, cert_reqs="CERT_REQUIRED", ca_certs=IPV6_ADDR_CA
+            "[::1]",
+            ipv6_addr_server.port,
+            cert_reqs="CERT_REQUIRED",
+            ca_certs=ipv6_addr_server.ca_certs,
         ) as https_pool:
             r = https_pool.request("GET", "/")
             assert r.status == 200
 
 
-class TestHTTPS_IPV6SAN(IPV6HTTPSDummyServerTestCase):
-    certs = IPV6_SAN_CERTS
-
-    def test_can_validate_ipv6_san(self):
+class TestHTTPS_IPV6SAN:
+    @pytest.mark.skipif(not HAS_IPV6, reason="Only runs on IPv6 systems")
+    def test_can_validate_ipv6_san(self, ipv6_san_server):
         """Ensure that urllib3 can validate SANs with IPv6 addresses in them."""
         try:
             import ipaddress  # noqa: F401
         except ImportError:
             pytest.skip("Only runs on systems with an ipaddress module")
 
         with HTTPSConnectionPool(
-            "[::1]", self.port, cert_reqs="CERT_REQUIRED", ca_certs=IPV6_SAN_CA
+            "[::1]",
+            ipv6_san_server.port,
+            cert_reqs="CERT_REQUIRED",
+            ca_certs=ipv6_san_server.ca_certs,
         ) as https_pool:
             r = https_pool.request("GET", "/")
             assert r.status == 200