Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Releases 1.22.2 and 2.0.0 #935

Merged
merged 6 commits into from
Nov 21, 2019
Merged

Releases 1.22.2 and 2.0.0 #935

merged 6 commits into from
Nov 21, 2019

Conversation

@coilysiren coilysiren changed the title v1 and v2 releases [ 🚧 WIP 🚧 ] v1 and v2 releases Nov 18, 2019
@coilysiren coilysiren self-assigned this Nov 18, 2019
@coilysiren coilysiren changed the title [ 🚧 WIP 🚧 ] v1 and v2 releases [ 🚧 WIP 🚧 ] Releases 1.22.2 and 2.0.0 Nov 18, 2019
@coilysiren coilysiren changed the title [ 🚧 WIP 🚧 ] Releases 1.22.2 and 2.0.0 Releases 1.22.2 and 2.0.0 Nov 18, 2019
@urfave urfave deleted a comment from codecov bot Nov 18, 2019
@urfave urfave deleted a comment from codecov bot Nov 18, 2019
@coilysiren coilysiren marked this pull request as ready for review November 18, 2019 06:44
@coilysiren coilysiren requested a review from a team as a code owner November 18, 2019 06:44
@codecov
Copy link

codecov bot commented Nov 18, 2019

Codecov Report

Merging #935 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #935   +/-   ##
=======================================
  Coverage   72.89%   72.89%           
=======================================
  Files          32       32           
  Lines        2439     2439           
=======================================
  Hits         1778     1778           
  Misses        550      550           
  Partials      111      111

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47016a6...2a06023. Read the comment docs.

Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coilysiren coilysiren merged commit a560b5c into master Nov 21, 2019
@coilysiren coilysiren deleted the v1v2release branch November 21, 2019 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants