lint + DefaultCommand #662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I missed this somehow, will review soon. |
jszwedko
requested changes
Jan 22, 2018
app.go
Outdated
| @@ -480,3 +480,11 @@ func (a *Author) String() string { | |||
|
|
|||
| return fmt.Sprintf("%v%v", a.Name, e) | |||
| } | |||
|
|
|||
| // DefaultAppComplete returns an ActionFunc to run a default command if non were passed. | |||
| // Usage: `app.Action = DefaultCommand("command")` | |||
There was a problem hiding this comment.
Because the target of this comment is likely to be end-users, could we use cli.DefaultCommand("command")?
flag.go
Outdated
| @@ -778,7 +778,7 @@ func visibleFlags(fl []Flag) []Flag { | |||
| func prefixFor(name string) (prefix string) { | |||
| if len(name) == 1 { | |||
| prefix = "-" | |||
| } else { | |||
| } else if name[0] != '-' { | |||
There was a problem hiding this comment.
Did you mean to include this change? It seems unrelated.
There was a problem hiding this comment.
Oops, yeah, I don't even remember why I did that, but I needed it for something, removed it tho.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a global function that can be passed to app.Action to execute a default command.
Fixes #657