Merge pull request #955 from urfave/inconsistent-version-behaviour-v2

Hide version info if user has not defined version [v2]
urfave · Nov 28, 2019 · a7cc974 · a7cc974
2 parents 6d64fe0 + 286ffd2
commit a7cc974
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 13 deletions.
diff --git a/app.go b/app.go
@@ -110,7 +110,6 @@ func NewApp() *App {
 		HelpName:     filepath.Base(os.Args[0]),
 		Usage:        "A new cli application",
 		UsageText:    "",
-		Version:      "0.0.0",
 		BashComplete: DefaultAppComplete,
 		Action:       helpCommand.Action,
 		Compiled:     compileTime(),
@@ -141,7 +140,7 @@ func (a *App) Setup() {
 	}
 
 	if a.Version == "" {
-		a.Version = "0.0.0"
+		a.HideVersion = true
 	}
 
 	if a.BashComplete == nil {

diff --git a/app_test.go b/app_test.go
@@ -192,15 +192,11 @@ func ExampleApp_Run_noAction() {
 	// USAGE:
 	//    greet [global options] command [command options] [arguments...]
 	//
-	// VERSION:
-	//    0.0.0
-	//
 	// COMMANDS:
 	//    help, h  Shows a list of commands or help for one command
 	//
 	// GLOBAL OPTIONS:
-	//    --help, -h     show help (default: false)
-	//    --version, -v  print the version (default: false)
+	//    --help, -h  show help (default: false)
 }
 
 func ExampleApp_Run_subcommandNoAction() {
@@ -256,8 +252,6 @@ func ExampleApp_Run_bashComplete_withShortFlag() {
 	// -x
 	// --help
 	// -h
-	// --version
-	// -v
 }
 
 func ExampleApp_Run_bashComplete_withLongFlag() {

diff --git a/docs/v2/manual.md b/docs/v2/manual.md
@@ -154,14 +154,11 @@ NAME:
 USAGE:
     greet [global options] command [command options] [arguments...]
 
-VERSION:
-    0.0.0
-
 COMMANDS:
     help, h  Shows a list of commands or help for one command
 
 GLOBAL OPTIONS
-    --version Shows version information
+    --help, -h  show help (default: false)
 ```
 
 ### Arguments