Merge pull request #978 from urfave/context-is-set-fix-v1

Context is set fix v1

.gitignore

@@ -1,3 +1,4 @@
 *.coverprofile
 node_modules/
-vendor
+vendor
+.idea

context.go

@@ -87,6 +87,14 @@ func (c *Context) IsSet(name string) bool {
 		for _, f := range flags {
 			eachName(f.GetName(), func(name string) {
 				if isSet, ok := c.setFlags[name]; isSet || !ok {
+					// Check if a flag is set
+					if isSet {
+						// If the flag is set, also set its other aliases
+						eachName(f.GetName(), func(name string) {
+							c.setFlags[name] = true
+						})
+					}
+
 					return
 				}
 

context_test.go

@@ -182,6 +182,51 @@ func TestContext_IsSet(t *testing.T) {
 	expect(t, c.IsSet("myflagGlobal"), false)
 }
 
+func TestContext_IsSet_ShortAndFull_FlagNames(t *testing.T) {
+	var (
+		numberIsSet, nIsSet bool
+		tempIsSet, tIsSet bool
+		usernameIsSet, uIsSet bool
+		debugIsSet, dIsSet bool
+	)
+
+	a := App {
+		Flags: []Flag{
+			IntFlag{Name: "number, n"},
+			Float64Flag{Name: "temp, t"},
+			StringFlag{Name: "username, u"},
+			BoolFlag{Name: "debug, d"},
+		},
+		Action: func(ctx *Context) error {
+			numberIsSet = ctx.IsSet("number")
+			nIsSet = ctx.IsSet("n")
+			tempIsSet = ctx.IsSet("temp")
+			tIsSet = ctx.IsSet("t")
+			usernameIsSet = ctx.IsSet("username")
+			uIsSet = ctx.IsSet("u")
+			debugIsSet = ctx.IsSet("debug")
+			dIsSet = ctx.IsSet("d")
+			return nil
+		},
+	}
+
+	tests := []struct {
+		args[]string
+	}{
+		{args: []string{"", "--number", "5", "--temp", "5.2", "--username", "ajitem", "--debug"}},
+		{args: []string{"", "-n", "5", "-t", "5.2", "-u", "ajitem", "-d"}},
+	}
+
+	for _, tt := range tests {
+		_ = a.Run(tt.args)
+
+		expect(t, numberIsSet == nIsSet, true)
+		expect(t, tempIsSet == tIsSet, true)
+		expect(t, usernameIsSet == uIsSet, true)
+		expect(t, debugIsSet == dIsSet, true)
+	}
+}
+
 // XXX Corresponds to hack in context.IsSet for flags with EnvVar field
 // Should be moved to `flag_test` in v2
 func TestContext_IsSet_fromEnv(t *testing.T) {