Updated for OTP v2 #2
Conversation
ikespand
commented
Dec 23, 2020
ikespand
commented
- In Dockerfile, changed the maven link and also the base image
- Updated ReadMe with new arguments and tutorial
- Updated Docker-compose
There was a problem hiding this comment.
Hey @ikespand
Thanks for the PR, but can you please explain your reasoning behind some changes in comments?
| @@ -1,10 +1,10 @@ | |||
| FROM java:8-alpine | |||
| LABEL maintainer="Stepan Kuzmin <to.stepan.kuzmin@gmail.com>" | |||
| FROM lpicanco/java11-alpine:11.0 | |||
There was a problem hiding this comment.
What is your reason to change the baseimage?
| -v $PWD:/graphs \ | ||
| -e JAVA_OPTIONS=-Xmx4G \ | ||
| urbica/otp --build /graphs | ||
| docker build -t my_docker_id/otp . |
There was a problem hiding this comment.
Why do you need this step? There is ready to use urbica/otp image
| Build the docker image from the Dockerfile: | ||
|
|
||
| ```shell | ||
| docker build -t ikespand/otp . |
There was a problem hiding this comment.
What is the reason changing urbica/otp to ikespand/otp?
| -e JAVA_OPTIONS=-Xmx4G \ | ||
| urbica/otp --basePath /data --server --analyst --autoScan --verbose | ||
| my_docker_id/otp --load /var/otp/graphs/city_name/ |
| otp --server --autoScan --verbose | ||
| -v $PWD/graphs:/var/otp/graphs \ | ||
| -e JAVA_OPTIONS=-Xmx4G \ | ||
| my_docker_id/otp --build \ |
There was a problem hiding this comment.
One can use urbica/otp image here
|
|
||
| ```shell | ||
| docker run \ | ||
| -p 8080:8080 \ | ||
| -v $PWD/graphs:/var/otp/graphs \ | ||
| -e JAVA_OPTIONS=-Xmx4G \ | ||
| urbica/otp --server --autoScan --verbose | ||
| ikespand/otp --load /var/otp/graphs/portland |
| urbica/otp --build /var/otp/graphs/portland | ||
| -v $PWD/graphs:/var/otp/graphs \ | ||
| -e JAVA_OPTIONS=-Xmx4G \ | ||
| ikespand/otp --build \ |
|
If I would Adresse the raised questions could this Mr be merged? We need an top 2 image and contributing seems reasonable. |
|
@stepankuzmin : Sorry, somehow I missed all updates related to this repo. This PR can be deleted now because @tarbaig have created a new PR which answers all the quries. |
