Release 15.2.0 #428
Release 15.2.0 #428
Conversation
|
|
||
| val listener = Listener( | ||
| listenerId = jsonArgs.get(1).requireInt(), | ||
| callbackContext = callbackContext | ||
| ) | ||
|
|
||
| this.listeners.getOrPut(event) { mutableListOf() }.add(listener) | ||
| this.listeners.getOrPut(eventName) { mutableListOf() }.add(listener) |
There was a problem hiding this comment.
No need to map to types, instead only use the map when finding the listener. This fixes background response and makes it so we can combine foreground/background push received
| @@ -396,7 +382,7 @@ internal fun JsonSerializable.pluginResult(): PluginResult { | |||
| val json = this.toJsonValue() | |||
|
|
|||
| return when { | |||
| json.isNull -> PluginResult(PluginResult.Status.OK) | |||
| json.isNull -> PluginResult(PluginResult.Status.OK, null as String?) | |||
There was a problem hiding this comment.
If you do not set a value on Android cordova it will set the value based on the status message.
|
@MaximBelov Could you review this? I want to make sure we are good to hopefully avoid another release. Thank you for all your help on this! |
|
Android Test1: Application not started, notification Test2: Application not started, application Test3: Application started, foreground Test4: Application started, background |
|
iOS Test1: Application not started, notification Test2: Application not started, application Test3: Application started, foreground Test4: Application started, background |
|
@rlepinski We need more internal tests with 15.2.0 codebase I'll let you know about any issues before 24.04.2024 |
|
@rlepinski |
|
@MaximBelov Awesome, Ill get a release out todayish, going to get another patch released SDK out first |
Still need new proxy and update iOS quiet time settings