Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the use of other mirrors instead of raw.githubusercontent.com #444

Merged
merged 6 commits into from
Aug 1, 2022
Merged

Conversation

poikcue
Copy link
Contributor

@poikcue poikcue commented Aug 1, 2022

I had a question the other day (at upptime/upptime#626)
In China for some reason some people may not be able to access raw.githubusercontent.com, so the status page will probably be inaccessible.
Therefore, I added a path to i18n.yml (GithubusercontentWebsiteUrl). This path defaults to raw.githubusercontent.com, however, the repository owner can modify it and use the raw.githubusercontent.com provided by others as needed raw.githubusercontent.com mirror service.

@upptime-bot
Copy link
Member

upptime-bot commented Aug 1, 2022

CLA Assistant Lite bot ✍️ All contributors have signed the CLA

@AnandChowdhary
Copy link
Member

This is great, thank you so much for the contribution! I just have one quick feedback: Since this is not related to translation, maybe it's better to rename the property to githubUserContentBaseUrl and put it directly in the configuration file rather than under i18n?

Copy link
Member

@AnandChowdhary AnandChowdhary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's a draft of how that can look like!

src/components/Summary.svelte Outdated Show resolved Hide resolved
src/components/LiveStatus.svelte Outdated Show resolved Hide resolved
i18n.yml Outdated Show resolved Hide resolved
poikcue and others added 3 commits August 1, 2022 18:38
Co-authored-by: Anand Chowdhary <github@anandchowdhary.com>
Co-authored-by: Anand Chowdhary <github@anandchowdhary.com>
Co-authored-by: Anand Chowdhary <github@anandchowdhary.com>
@poikcue
Copy link
Contributor Author

poikcue commented Aug 1, 2022

I have read the CLA Document and I hereby sign the CLA

@poikcue
Copy link
Contributor Author

poikcue commented Aug 1, 2022

This is great, thank you so much for the contribution! I just have one quick feedback: Since this is not related to translation, maybe it's better to rename the property to githubUserContentBaseUrl and put it directly in the configuration file rather than under i18n?

I edited it! (This is my first time using the GitHub PR feature and I may not be proficient yet, sorry!)

@AnandChowdhary
Copy link
Member

This is perfect, thanks!

@AnandChowdhary AnandChowdhary merged commit aeb6b33 into upptime:master Aug 1, 2022
@upptime upptime locked and limited conversation to collaborators Aug 1, 2022
@upptime-bot
Copy link
Member

🎉 This PR is included in version 1.14.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
3 participants