-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: Enable CA1805 analyzer and fix violations #6892
perf: Enable CA1805 analyzer and fix violations #6892
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jeromelaban Is is more manageable to review or do you want to break it more smaller?
f7914fa
to
1122c9d
Compare
d74193d
to
1905483
Compare
aa908d4
to
9346d04
Compare
9346d04
to
3914f5e
Compare
Build failure is likely due to increased build time with the addition of analyzers. I'll see if I can track down if there is a specific analyzer causing that. |
It may be caused by the analyzers, but yesterday's builds were particularly slow so it may be unrelated. |
Security analyzers are a bit slow because they do heavy data-flow analysis, and CA1041 is a bit slow too dotnet/roslyn-analyzers#6143 I'll disable security analyzers and keep CA1041 enabled. If it remains slow, I'll disable CA1041 too. |
Analyzer documentation.
GitHub Issue (If applicable): part of #6882
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Run
results.Other information
Internal Issue (If applicable):