Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update unlock-dao-tokens.mdx #14601

Merged
merged 23 commits into from
Sep 16, 2024
Merged

Update unlock-dao-tokens.mdx #14601

merged 23 commits into from
Sep 16, 2024

Conversation

ccarfi
Copy link
Contributor

@ccarfi ccarfi commented Sep 13, 2024

adding UP token FAQ and related content

adding UP token FAQ and related content
@cla-bot cla-bot bot added the cla-signed label Sep 13, 2024
Copy link
Member

@julien51 julien51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs improvement!

@ccarfi
Copy link
Contributor Author

ccarfi commented Sep 13, 2024

This needs improvement!

@julien51 yes; was not ready for review yet. it is still work in process on a branch, with placeholders (e.g. "put graph here", need to add images for logos, etc.)

since builds take a long time, i kicked it off before i went to sleep so i'd have a page to look at on my branch when i woke up this morning.

will ping you when it's ready for review!

@julien51 julien51 marked this pull request as draft September 13, 2024 13:50
@ccarfi ccarfi marked this pull request as ready for review September 14, 2024 03:35
/>

# UP & UDT Addresses
## UDT Contract Addresses
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically, the component below renders whatever governance token is set as the reward on per network. Right now, it is indeed UDT on all networks, but in the next few days/weeks, it will show UP for the Base network.

Maybe we keep this list and for each network we show both addresses (when applicable) UDT and UP, as well as which token is "rewarded". In that case, I will change the name of this section for something like "UDT and UP addresses per network" ? wdyt?

At that point, the collected fees can be "swapped and burned" by calling the `swapAndBurn` function on the Unlock contract. This function will swap the collected fees for UP (or UDT) tokens on a decentralized exchange and then burn them.
Current, the protocol fees collected by way of the fee switch can be "swapped and burned" by calling the `swapAndBurn` function on the Unlock contract. This function will swap the collected fees for UP (or UDT) tokens on a decentralized exchange and then burn them.

## Bridging UDT from Mainnet to Base and Exchanging the UDT for the Unlock Protocol UP Token
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks a bit strange.

Screenshot 2024-09-16 at 4 45 06 PM

Maybe we need to make this title shorter?

Copy link
Member

@julien51 julien51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor notes!

Co-authored-by: Julien Genestoux <julien.genestoux@gmail.com>
@ccarfi ccarfi merged commit cb220aa into master Sep 16, 2024
10 of 12 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants