Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: rename routeOptions to routeRules #593

Merged
merged 4 commits into from
Oct 17, 2022
Merged

refactor!: rename routeOptions to routeRules #593

merged 4 commits into from
Oct 17, 2022

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This renames a number of route rule related utilities + config to use route rules rather than route options. This is a breaking change only for users tracking nitropack-edge.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

src/runtime/route-options.ts Outdated Show resolved Hide resolved
src/types/nitro.ts Outdated Show resolved Hide resolved
@pi0 pi0 changed the title refactor!: rename NitroRouteOptions -> NitroRouteRules refactor!: rename routeOptions to routeRules Oct 17, 2022
@codecov
Copy link

codecov bot commented Oct 17, 2022

Codecov Report

Merging #593 (8f5667f) into main (5c2c313) will increase coverage by 0.02%.
The diff coverage is 88.09%.

@@            Coverage Diff             @@
##             main     #593      +/-   ##
==========================================
+ Coverage   66.09%   66.12%   +0.02%     
==========================================
  Files          55       55              
  Lines        4109     4112       +3     
  Branches      444      444              
==========================================
+ Hits         2716     2719       +3     
  Misses       1389     1389              
  Partials        4        4              
Impacted Files Coverage Ξ”
src/options.ts 85.29% <85.71%> (+0.16%) ⬆️
src/presets/netlify.ts 53.67% <87.50%> (ΓΈ)
src/presets/vercel.ts 64.46% <87.50%> (ΓΈ)
src/imports.ts 100.00% <100.00%> (ΓΈ)
src/types/nitro.ts 100.00% <100.00%> (ΓΈ)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pi0 pi0 merged commit 4ff7082 into main Oct 17, 2022
@pi0 pi0 deleted the refactor/rules branch October 17, 2022 13:14
WinterYukky pushed a commit to WinterYukky/nitro that referenced this pull request Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants