-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(netlify): incremental static regeneration + swr #540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #540 +/- ##
==========================================
+ Coverage 66.04% 66.09% +0.05%
==========================================
Files 55 55
Lines 4049 4056 +7
Branches 437 438 +1
==========================================
+ Hits 2674 2681 +7
Misses 1371 1371
Partials 4 4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
I believe seconds makes more sense personally :) |
This was referenced Oct 4, 2022
atinux
approved these changes
Oct 11, 2022
pi0
reviewed
Oct 12, 2022
WinterYukky
pushed a commit
to WinterYukky/nitro
that referenced
this pull request
Nov 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
resolves #93
β Type of change
π Description
This PR adapts the
netlify
preset to support theswr
/static
route rule for dynamic on-demand builder configuration.For example, the following config would use builder functions only for the blog & articles routes. The blog routes would be generated only once and then persisted; the articles routes would be regenerated every 360 seconds.
Here's a deployment using this PR: https://main--melodious-klepon-3a2ccb.netlify.app
Note: we pass the value ofswr
directly through tottl
but it is expressed in the Netlify docs in seconds and we should likely specify what the number means - e.g. seconds or milliseconds, etc.π Checklist