Datagen: move HashSet to the trait and other small cleanups #4473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sffc
commented
Dec 19, 2023
Comment on lines
+36
to
39
| impl IterableDataProvider<$marker> for crate::DatagenProvider { | ||
| fn supported_locales(&self) -> Result<Vec<DataLocale>, DataError> { | ||
| Ok(vec![DataLocale::default()]) | ||
| } |
There was a problem hiding this comment.
Note: I left the trivial impls directly with IterableDataProvider in the previous PR but accidentally migrated this trivial impl.
Comment on lines
-75
to
+77
| fn supported_locales(&self) -> Result<Vec<DataLocale>, DataError> { | ||
| fn supported_locales_for_numbers(&self) -> Result<HashSet<DataLocale>, DataError> { |
There was a problem hiding this comment.
This poorly named function has been around for a long time and I hope it didn't cause confusion. It dates to the time when each transformer was implemented on its own struct.
Manishearth
approved these changes
Dec 19, 2023
|
while you're in here please put the performance improvements in the changelog |
|
Changelog in #4484 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just some more things I had on my branch. No appreciable impact on performance (54.17, 58.70, 52.65).