Display elapsed time in datagen log #4469
Conversation
provider/datagen/src/driver.rs
Outdated
| .into_par_iter() | ||
| .map(|locale| { | ||
| let instant2 = Instant::now(); | ||
| load_with_fallback(key, &locale) |
There was a problem hiding this comment.
Do double-check that the old and new behaviors are the same. I switched things around to avoid duplicating the duration logic.
provider/datagen/src/driver.rs
Outdated
| let instant2 = Instant::now(); | ||
| load_with_fallback(key, &locale) | ||
| .transpose()? | ||
| .map(|payload| sink.put_payload(key, &locale, &payload)) |
There was a problem hiding this comment.
nit: I'm not convinced the functional style is clearer here, especially with the timing code, where you kinda actually do need to know where it should run. I think we should revert to the older imperative style here and just add timing
There was a problem hiding this comment.
In general I agree but in this case I was confused why we had an expression like
if let Some(payload) = load_with_fallback(key, &locale) {
sink.put_payload(key, &locale, &payload?)
} else {
Ok(())
}
// followed by other chaining logicAlso note that the majority of the diff in this branch is due to changing try_for_each to map so that I can call .max() on the result.
I will do another round of making this more clear though. I realized that I might be losing the error context with the new .transpose()?
|
Is this changelog worthy? |
|
shrug when I make a changelog manually I would include this. Otherwise ... eh |
|
Changelog in #4484 |
Makes the output more useful/actionable.
cargo make testdata: