Canonicalize tlangs to lowercase
#4134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedel1043
requested review from
sffc,
robertbastian,
Manishearth and
a team
as code owners
| { | ||
| "input": { | ||
| "type": "Locale", | ||
| "identifier": "en-t-en-Latn-CA-emodeng" |
There was a problem hiding this comment.
please test uppercase variants
sffc
previously approved these changes
Oct 9, 2023
sffc
previously approved these changes
Oct 9, 2023
|
Huh, |
Sporadic failure. I requested a re-run. |
robertbastian
previously approved these changes
Oct 9, 2023
zbraniecki
reviewed
Oct 9, 2023
components/locid/src/langid.rs
Outdated
| @@ -327,6 +327,38 @@ impl LanguageIdentifier { | |||
| } | |||
| Ok(()) | |||
| } | |||
|
|
|||
| pub(crate) fn for_each_subtag_str_lowercase<E, F>(&self, f: &mut F) -> Result<(), E> | |||
There was a problem hiding this comment.
can you document why we need this function here? Explain that tlang canonicalizes differently.
components/locid/src/langid.rs
Outdated
| Ok(()) | ||
| } | ||
|
|
||
| pub(crate) fn write_to_lowercase<W: core::fmt::Write + ?Sized>( |
| let path = "./tests/fixtures/canonicalize.json"; | ||
| let data = helpers::read_fixture(path).expect("Failed to read a fixture"); | ||
|
|
||
| test_langid_fixtures(data); |
There was a problem hiding this comment.
thank you for turning this into data-driven test!
|
The error seems to be similar to myoung34/docker-github-actions-runner#322, so maybe the container just needs to be removed to free its storage? |
sffc
approved these changes
Oct 9, 2023
robertbastian
approved these changes
Oct 10, 2023
jedel1043
force-pushed
the
lowercase-tlangs
branch
from
4a6c072
to
d630b1f
Compare
|
Friendly ping to note that this can be merged now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1925
For simplicity I didn't add
write_to_lowercasemethods forScriptandRegion, but let me know if that would be preferable.