Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICU-22790 Out-of-bounds read in countSpaces() found by CHERI #3024

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ICU-22790 Out-of-bounds read in countSpaces() found by CHERI #3024

wants to merge 1 commit into from
+1 −3

Conversation

kwitaszczyk
Copy link

@kwitaszczyk kwitaszczyk commented Jun 4, 2024 •
edited by markusicu
Loading

Checklist
  • Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22790
  • Required: The PR title must be prefixed with a JIRA Issue number.
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number.
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

@kwitaszczyk
ICU-22790 Eliminate an out-of-bounds read
80a9502 
Check if an iterator is within bounds before accessing memory.
Also, remove a redundant variable to make the while condition more
clear.

This issue was found [1] by running Konsole on CheriBSD/Morello that was
compiled for CheriABI. The out of bounds read triggered a CHERI
capability violation.

[1] CTSRD-CHERI/cheribsd-ports#160
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@kwitaszczyk kwitaszczyk mentioned this pull request Jun 4, 2024
Open
@markusicu
Copy link
Member

Waiting for the CLA to be signed

@kwitaszczyk
Copy link
Author

Waiting for the CLA to be signed

@markusicu Thank you for the reminder. FYI I'm waiting for an approval from my employer to do this.

@markusicu
Copy link
Member

Waiting for the CLA to be signed

@markusicu Thank you for the reminder. FYI I'm waiting for an approval from my employer to do this.

Any news?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla-needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kwitaszczyk @CLAassistant @markusicu