Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes and expand quantus.evaluate func #314

Merged
merged 16 commits into from
Nov 27, 2023
Merged

Conversation

annahedstroem
Copy link
Member

@annahedstroem annahedstroem commented Nov 26, 2023

Description

  • Small changes, non-breaking

Implemented changes

  • Expand docstring on quatus.evaluate and add additional arguments
    • return as df
    • expand docstrings
    • verbose argument to print progress
    • removing call kwargs from results if unused
    • update test cases of eval function to mirror documentation
  • Bugfix on EfficientMPRT
    • adding shaping of input for tf models
    • if skip_layers=True, moving down if statement after original (important bugfix!)

Minimum acceptance criteria

  • Specify what is necessary for the PR to be merged with the main branch.
  • @mentions of the person that is apt to review these changes e.g., @annahedstroem

@codecov-commenter
Copy link

codecov-commenter commented Nov 27, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (909211a) 91.27% compared to head (bb2fbc8) 91.24%.

Files Patch % Lines
quantus/evaluation.py 74.07% 7 Missing ⚠️
quantus/metrics/randomisation/mprt.py 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #314      +/-   ##
==========================================
- Coverage   91.27%   91.24%   -0.03%     
==========================================
  Files          66       66              
  Lines        3861     3884      +23     
==========================================
+ Hits         3524     3544      +20     
- Misses        337      340       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@annahedstroem annahedstroem merged commit ee64963 into main Nov 27, 2023
7 checks passed
@annahedstroem annahedstroem deleted the evaluate_func branch November 27, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants