Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review distance metrics and added squared distance as measure #264

Merged
merged 8 commits into from
May 17, 2023

Conversation

annahedstroem
Copy link
Member

Description

  • TBD

Implemented changes

  • TBD

Minimum acceptance criteria

  • Specify what is necessary for the PR to be merged with the main branch.
  • @mentions of the person that is apt to review these changes e.g., @annahedstroem

@codecov-commenter
Copy link

codecov-commenter commented May 17, 2023

Codecov Report

Merging #264 (312e6d5) into main (42c7054) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main     #264   +/-   ##
=======================================
  Coverage   92.87%   92.87%           
=======================================
  Files          60       60           
  Lines        3198     3200    +2     
=======================================
+ Hits         2970     2972    +2     
  Misses        228      228           
Impacted Files Coverage Δ
quantus/functions/similarity_func.py 97.14% <100.00%> (+0.17%) ⬆️

@annahedstroem annahedstroem merged commit 344e611 into main May 17, 2023
7 checks passed
@aaarrti aaarrti deleted the review-dist-metrics branch June 7, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants