Fix warn_perturbation_caused_no_change #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #250 +/- ##
=======================================
Coverage 92.86% 92.86%
=======================================
Files 60 60
Lines 3196 3196
=======================================
Hits 2968 2968
Misses 228 228
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
annahedstroem
approved these changes
Apr 12, 2023
There was a problem hiding this comment.
Super, thank you so much for these changes @p-wojciechowski
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The previous implementation of
warn_perturbation_caused_no_changeraises a warning if any element of the perturbed input differs from the original input. This behaviour contradicts the function name. Additionally, comparing floats with the==operator can be problematic (false negatives) due to error accumulation during float operations.After this fix, warnings about no change in perturbation won't be raised if there has actually been a change in input. Moreover, the condition for raising the warning handles floats well by using
np.allclose.Implemented changes