Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cosmetic usability improvements #88

Closed
Kizaemon opened this issue Aug 22, 2021 · 3 comments
Closed

Cosmetic usability improvements #88

Kizaemon opened this issue Aug 22, 2021 · 3 comments
Labels
enhancement New feature or request
Milestone
0.12.0

Comments

@Kizaemon
Copy link

Thank you for your library of tweaks!

I noticed two minor usability issues, which could be improved.
This is the online version for windows, card layout.
I tried with Firefox and Opera.

  1. Expand a card on the left side, and select an item (checkbox) inside of that card -- a script is generated at the right side.
    Now when I select any characters in the generated script, the card is collapsing and I'm losing the context of what card/checkbox I selected last.

It would be great to keep the left side card expansion state unchanged, when navigating in the script.
The tree layout has not the problem of losing collapsing/losing context.

  1. When copying few lines of the script to clipboard, the lines are separated with LF, not CRLF.
    I need to fixup new lines breaks in an editor (Notepad++) before running the selected lines in command prompt.
    I understand your intent is to download the script as a bat file, but I'd like to have an option to run selected lines only.

It would be great if the Windows version would use CRLF when copying to clipboard.
@undergroundwires undergroundwires added this to the 0.11.0 milestone Aug 23, 2021
@undergroundwires
Copy link
Owner

Hi @Kizaemon , welcome to the community. Thank you for using it and your valuable feedback. Both suggestions will be implemented.

  1. It was implemented for mobile users. I noticed that clicking on run/download buttons on bottom do the same which is intrusive. I'll fix both.

  2. You're right, we need to address this. I see three options going forward:

a. Based on client OS: use LF for Unix-based systems and CRLF for Windows, regardless of bash/batch file
b. Based on language: Use CRLF for batch files, LF for bash, regardless of client OS
c. Always use CRLF regardless of platform. Seems to be simplest option. Is there any disadvantages to this?

How do you think we should go forward?

undergroundwires added a commit that referenced this issue Sep 3, 2021
@undergroundwires
Do not collapse cards on links and code area #88
e73c0ad 
Detects clickable elements automatically and exempts them from
collapsing cards, also interacting with code area does no longer
collapse cards.

This commit also fixes subscribing to clicks on document every time card
list is loaded, but never unsubscribing. This impacts performance and
causes memory leaks. Now, registered event listener is removed every
time card list component is destroyed.
@undergroundwires undergroundwires added the enhancement New feature or request label Sep 3, 2021
@undergroundwires
Copy link
Owner

Bash [does not seem to accept CRLF, then generated batch files will be using CRLF and bash LF. So we'll go with option b.

@Kizaemon in your case you were having the issue with about copying from generated script files, not on the textbox on website/desktop app right?

@undergroundwires undergroundwires modified the milestones: 0.11.0, 0.12.0 Nov 13, 2021
undergroundwires added a commit that referenced this issue Sep 28, 2022
@undergroundwires
Use line endings based on script language #88
6b3f465 
Use CRLF in batchfile and LF in shellscript.
@undergroundwires
Copy link
Owner

undergroundwires commented Aug 3, 2023 •
edited
Loading

Released in 0.12.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.12.0
Development

No branches or pull requests
2 participants
@undergroundwires @Kizaemon