Skip to content

Commit

Permalink
ci/cd: fix quality checks not running on all OSes
Browse files Browse the repository at this point in the history
Previously, quality checks were mistakenly configured to run only on
Ubuntu.

This commit modifies the CI/CD workflow to use the matrix strategy,
allowing the quality checks to be executed on macOS, Ubuntu and Windows.

Additionally, this update resolves the `MD034/no-bare-urls Bare URL
used` linting error that surfaced when testing on Windows.
  • Loading branch information
undergroundwires committed May 18, 2024
1 parent 9ab3ff7 commit 2390530
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/checks.quality.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ on: [ push, pull_request ]

jobs:
lint:
runs-on: ubuntu-latest
runs-on: ${{ matrix.os }}-latest
strategy:
matrix:
lint-command:
Expand Down
4 changes: 2 additions & 2 deletions tests/checks/external-urls/StatusChecker/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -105,5 +105,5 @@ console.log(`Status code: ${status.code}`);
- This is useful for websites that do not respond to HEAD requests, such as those behind certain CDN or web application firewalls.
- Provide patterns as regular expressions (`RegExp`), allowing them to match any part of a URL.
- Examples:
- To match any URL starting with "https://example.com/api": `/^https:\/\/example\.com\/api/`
- To match any domain ending with "cloudflare.com": `/^https:\/\/.*\.cloudflare\.com\//`
- To match any URL starting with `https://example.com/api`: `/^https:\/\/example\.com\/api/`
- To match any domain ending with `cloudflare.com`: `/^https:\/\/.*\.cloudflare\.com\//`

0 comments on commit 2390530

Please sign in to comment.