Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added property to configure purge options #1496

Merged

Conversation

AlexNetcare
Copy link
Contributor

Added the possibility to configure the purge options in the plugins.properties.
The new property can look like TestHistory.purgeTime=0,30,60,90 and changes the buttons on the Test History page. Will default to 0,7,30 when nothing else is configured.
Also changed the purge behaviour to only delete the current page. But also with an option to still purge globally by checking the Purge Global button.

Depending on the configured purge times, the GUI for the Test Histories would look like this:
image

@AlexNetcare
Copy link
Contributor Author

Hello @fhoeben,
would it be possible that this PR could be reviewed? I have a couple other changes regarding test histories I would like to create PRs for, but I don't want to create any conflicts.

@fhoeben
Copy link
Collaborator

fhoeben commented Mar 22, 2024

@AlexNetcare sorry I haven't gotten around to this yet. I will try to look at it this weekend

Copy link
Collaborator

@fhoeben fhoeben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good. Some minor suggestions and one possible enhancement

plugins.properties Outdated Show resolved Hide resolved
plugins.properties Outdated Show resolved Hide resolved
src/fitnesse/resources/javascript/fitnesse.js Outdated Show resolved Hide resolved
src/fitnesse/resources/javascript/fitnesse.js Outdated Show resolved Hide resolved
src/fitnesse/resources/javascript/fitnesse.js Outdated Show resolved Hide resolved
src/fitnesse/resources/javascript/fitnesse.js Outdated Show resolved Hide resolved
@fhoeben fhoeben merged commit 95693ec into unclebob:master Apr 25, 2024
1 check passed
@AlexNetcare AlexNetcare deleted the feature/add-configurable-purge-options branch May 3, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants