Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't load kitten picture from third party site #1736

Merged
merged 4 commits into from
Feb 3, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion frontend/Dockerfile.e2e
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ WORKDIR /frontend

COPY ./package.json ./pnpm-workspace.yaml ./pnpm-lock.yaml /frontend/
COPY ./e2e/package.json /frontend/e2e/
RUN corepack enable pnpm && pnpm install
RUN corepack enable && corepack prepare pnpm@7.33.6 --activate && pnpm install

COPY ./e2e/playwright.config.ts /frontend/e2e/
COPY ./e2e/tests /frontend/e2e/tests/
Expand Down
3 changes: 2 additions & 1 deletion frontend/apps/remark42/.stylelintignore
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
node_modules
public
extracted-messages
extracted-messages
*.jpeg
1 change: 1 addition & 0 deletions frontend/apps/remark42/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@
"babel-plugin-jsx-remove-data-test-id": "^3.0.0",
"clean-webpack-plugin": "^4.0.0",
"codecov": "^3.8.3",
"copy-webpack-plugin": "^12.0.2",
"cross-env": "^7.0.3",
"css-loader": "^6.7.1",
"css-minimizer-webpack-plugin": "^4.0.0",
Expand Down
Binary file added frontend/apps/remark42/templates/400x400.jpeg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion frontend/apps/remark42/templates/markdown-help.html
Original file line number Diff line number Diff line change
Expand Up @@ -348,7 +348,7 @@ <h2 id="Images">Images</h2>
<p>If you want to embed images, this is how you do it:</p>
<pre>![Image of my cat](https://placekitten.com/400/400)</pre>
<p>
<img src="https://placekitten.com/400/400" width="400" height="400" alt="" />
<img src="400x400.jpeg" width="400" height="400" alt="" />
</p>

<h2 id="Code">Code</h2>
Expand Down
9 changes: 9 additions & 0 deletions frontend/apps/remark42/webpack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ const webpack = require('webpack');
const MiniCssExtractPlugin = require('mini-css-extract-plugin');
const { CleanWebpackPlugin } = require('clean-webpack-plugin');
const HtmlWebpackPlugin = require('html-webpack-plugin');
const CopyPlugin = require('copy-webpack-plugin');
const TsconfigPathsPlugin = require('tsconfig-paths-webpack-plugin');
const ForkTsCheckerWebpackPlugin = require('fork-ts-checker-webpack-plugin');
const RefreshPlugin = require('@prefresh/webpack');
Expand Down Expand Up @@ -294,6 +295,14 @@ module.exports = (_, { mode, analyze }) => {
},
plugins: [
...plugins,
new CopyPlugin({
patterns: [
{
from: path.resolve(__dirname, 'templates/400x400.jpeg'),
to: PUBLIC_FOLDER_PATH,
},
],
}),
new ForkTsCheckerWebpackPlugin(),
new HtmlWebpackPlugin({
template: path.resolve(__dirname, 'templates/iframe.ejs'),
Expand Down
81 changes: 81 additions & 0 deletions frontend/pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading