Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow disabling fancy comment text formatting #1700

Merged
merged 1 commit into from
Nov 26, 2023
Merged

Conversation

paskal
Copy link
Sponsor Collaborator

@paskal paskal commented Nov 18, 2023

It might be necessary if the comments should preserve original quotes instead of replacing them with angled ones.

Resolves #1666.

Copy link

github-actions bot commented Nov 18, 2023

Pull Request Test Coverage Report for Build 6991065183

  • 55 of 55 (100.0%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.006%) to 84.773%

Totals Coverage Status
Change from base Build 6933314945: 0.006%
Covered Lines: 5907
Relevant Lines: 6968

💛 - Coveralls

akellbl4
akellbl4 previously approved these changes Nov 25, 2023
Copy link
Collaborator

@akellbl4 akellbl4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! One thing about the name of the param. SmartyPants is about punctuation "enhancement" and it has nothing to do with HTML itself.

It might be necessary if the comments should preserve
original quotes instead of replacing them with angled ones.
Copy link
Owner

@umputun umputun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paskal paskal merged commit dcc7613 into master Nov 26, 2023
4 checks passed
@paskal paskal deleted the paskal/raw_quotes branch November 26, 2023 08:13
@paskal paskal changed the title Allow disabling fancy HTML formatting Allow disabling fancy comment text formatting Nov 26, 2023
@paskal paskal added this to the v1.13.0 milestone Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Double-quote characters in comments show as guillemets in output
3 participants