Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update iframe size on textarea size change #1541

Merged
merged 1 commit into from
Dec 3, 2022

Conversation

akellbl4
Copy link
Collaborator

@akellbl4 akellbl4 commented Dec 2, 2022

Addressing this comment

MutationObserver doesn't spot some changes on textarea value changes (expecially on paste) so we add additional resize event on textarea size updates.

cc @damienalexandre

@github-actions
Copy link

github-actions bot commented Dec 2, 2022

size-limit report 📦

Path Size
public/embed.mjs 2.03 KB (0%)
public/remark.mjs 73.07 KB (+0.06% 🔺)
public/remark.css 8.12 KB (+0.02% 🔺)
public/last-comments.mjs 35.83 KB (0%)
public/last-comments.css 3.72 KB (0%)
public/deleteme.mjs 12.05 KB (0%)
public/counter.mjs 749 B (0%)

@codecov
Copy link

codecov bot commented Dec 2, 2022

Codecov Report

Base: 57.95% // Head: 58.04% // Increases project coverage by +0.09% 🎉

Coverage data is based on head (3bdbbfb) compared to base (6fe373d).
Patch coverage: 85.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1541      +/-   ##
==========================================
+ Coverage   57.95%   58.04%   +0.09%     
==========================================
  Files         131      131              
  Lines        2916     2920       +4     
  Branches      745      746       +1     
==========================================
+ Hits         1690     1695       +5     
+ Misses       1094     1093       -1     
  Partials      132      132              
Impacted Files Coverage Δ
...rontend/apps/remark42/app/components/root/root.tsx 0.00% <ø> (ø)
frontend/apps/remark42/app/utils/post-message.ts 50.00% <50.00%> (ø)
...apps/remark42/app/components/textarea-autosize.tsx 90.47% <88.23%> (+1.58%) ⬆️
...ark42/app/components/comment-form/comment-form.tsx 51.94% <100.00%> (+0.23%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@paskal paskal added this to the v1.11.2 milestone Dec 3, 2022
@umputun umputun merged commit 68b8468 into master Dec 3, 2022
@umputun umputun deleted the akellbl4/update-iframe-size-on-input branch December 3, 2022 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants