-
-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use workspaces #1417
use workspaces #1417
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1417 +/- ##
==========================================
+ Coverage 58.00% 58.12% +0.12%
==========================================
Files 131 131
Lines 2900 2909 +9
Branches 699 743 +44
==========================================
+ Hits 1682 1691 +9
+ Misses 1214 1087 -127
- Partials 4 131 +127 Continue to review full report at Codecov.
|
24259ca
to
e9d24aa
Compare
Pull Request Test Coverage Report for Build 2665445563
💛 - Coveralls |
bbc054c
to
1c17abe
Compare
f9397be
to
8dee468
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, except for the fact that this change can't go without a single .md
file change. Something should be altered in the frontend dev documentation and maybe a Readme file.
Also please don't merge before #1422, I would like to rebase with newer Dockerfile. |
7b187e8
to
07584ee
Compare
To be precise, I want to see edits in https://github.com/umputun/remark42/blob/master/site/src/docs/contributing/development/frontend/index.md. |
A part of #1409
frontend
tofrontend/apps/remark42
(99% of changes)Note:
size-limit
is crashing because code was moved and it expects it in the same place (when runs check on master)